[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: rev 5621 - trunk/subversion/libsvn_diff

From: Sander Striker <striker_at_apache.org>
Date: 2003-04-15 02:24:34 CEST

> From: Greg Stein [mailto:gstein@lyra.org]
> Sent: Tuesday, April 15, 2003 2:20 AM

[...]
> That seems like the wrong test. Don't you want to check file_baton->buffer
> rather than finfo.size? Your comment is about a NULL pointer, so check the
> pointer value, not an unrelated size.

Thanks for the review Greg. This logic is going away as is though, since Branes
tests have been failing on HP-UX for quite a while due to over aggressive mmap'ing.
After I get some sleep I'll be committing a fix for that.

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 15 02:25:18 2003

This is an archived mail posted to the Subversion Dev mailing list.