[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Very Simple patch to made error message more verbose

From: Jani Averbach <jaa_at_cc.jyu.fi>
Date: 2003-04-11 01:39:26 CEST

Hello!

With this change subversion will print also sheme and host when failing
connect to server. I made "make check" over dav, and everything is still
allright (as you could guess). There is no big need for this change, I
just like to see what sheme and server was when connection fails.

Old message:
svn: RA layer request failed
svn: REPORT request failed on /repos/svn/trunk
svn: REPORT of /repos/svn/trunk: could not connect to server

New message:
svn: RA layer request failed
svn: REPORT request failed on '/repos/svn/trunk'
svn: REPORT of '/repos/svn/trunk': could not connect to server (http://svn.collab.net)

Log:

Changed svn_ra_dav__convert_error to print also sheme and host when
connection fails. This will also print the port after host, if it is
different than 80.

* subversion/libsvn_ra_dav/util.c:
  (svn_ra_dav__convert_error) include also sheme and host to error
                              string.

Index: subversion/libsvn_ra_dav/util.c
===================================================================
--- subversion/libsvn_ra_dav/util.c (revision 5598)
+++ subversion/libsvn_ra_dav/util.c (working copy)
@@ -78,7 +78,9 @@
       break;
     }

- return svn_error_createf (errcode, NULL, "%s: %s", context, msg);
+ return svn_error_createf (errcode, NULL, "%s: %s (%s://%s)",
+ context, msg, ne_get_scheme(sess),
+ ne_get_server_hostport(sess));

 }

-- 
Jani Averbach
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 11 01:40:11 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.