[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Python sub-process error checking

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2003-04-08 15:52:39 CEST

julianfoad@btopenworld.com writes:
> Perhaps I'm missing something, but I can't see when a crash would
> ever be the expected behaviour. Well, only in an XFAIL test (which
> is presumably a temporary measure), and in that case the worst I can
> imagine happening is that people see XFAIL tests passing on Windows
> and get confused about whether the corresponding bugs have actually
> been fixed.

Yes, you're missing something :-).

No one on this thread is arguing that crashes should ever be expected
behavior. The problem is that our test suite cannot reliably detect a
crash -- hence, it has to look for other things that can only happen
if there was *no* crash. If it fails to see those things, it can
assume something went wrong.

William/Philip posted a patch that would make it possible to detect
crashes directly, but not for all platforms. My paragraph was about
how it doesn't do us much good until it's portable, because we still
have to write tests the same way we have been.

So this isn't about XFAIL tests passing on Windows. It's about *any*
claiming to pass on Windows when in fact the 'svn' client seg faulted
under the hood. That's not good.

Make more sense now?


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 8 16:35:28 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.