Re: crash in server

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> I popped up to the frame in svn_repos_get_logs(). The relevant swath
> of code is near the end of that function:
>
> if ((this_rev > 0) && discover_changed_paths)

This condition...

> {
> svn_fs_root_t *newroot;
> changed_paths = apr_hash_make (subpool);
> SVN_ERR (svn_fs_revision_root (&newroot, fs, this_rev, subpool));
> SVN_ERR (detect_changed (changed_paths, newroot, subpool));
> }
>
> SVN_ERR ((*receiver) (receiver_baton,
> (discover_changed_paths ? changed_paths : NULL),

... is different from this condition.

> this_rev,
> author ? author->data : NULL,
> date ? date->data : NULL,
> message ? message->data : NULL,
> subpool));
>
>
> (It's using a subpool because it's looping over log messages, of
> course.)
>
> And that's all I know right now; don't know yet why/how changed_paths
> is screwed up. Working on it.

changed_paths gets initialised to NULL outside the loop. If this_rev
is zero on any iteration other than the first then changed_paths will
be rubbish.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org