[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_client_patch()

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-04-06 18:06:19 CEST

On Sunday, April 6, 2003, at 12:01 PM, SteveKing wrote:

>> On Sunday, April 6, 2003, at 11:37 AM, SteveKing wrote:
>>
>>> If the patch file doesn't have to be in a text like format so
>>> the user can read it then why not do this:
>>
>> if the patch isn't in text format, you're going to see a large
>> resistance to using it from most open source developers. mailing off
>> a
>> patch to a mailing list works well because one can just glance at it
>> and see what it's doing. if your proposed solution is something
>> opaque
>> (or even just cryptic text like the old xml stuff we had back in the
>> day), it seems like a showstopper to me.
>>
>> -garrett
>
> to make it 'readable' again:
> apply the patch
> do an svn diff > readable patch file
> svn revert
>
> I guess this won't make it a showstopper?

you've still taken a 1 step process ('look at the patch in the email
this guy just sent me') and made it into 5 ('receive email', 'detach
patch from email', 'apply it to correct version of the code', 'run svn
diff', 'look at what he changed'). in my mind, that's a showstopper.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 6 18:07:11 2003

This is an archived mail posted to the Subversion Dev mailing list.