Re: svn commit: rev 5549 - in trunk/subversion: clients/cmdline include libsvn_client libsvn_subr libsvn_wc

sussman@tigris.org wrote:

>Author: sussman
>Date: Thu Apr 3 23:54:47 2003
>New Revision: 5549
>
>Added:
> trunk/subversion/libsvn_client/providers.c
> - copied, changed from rev 5542, trunk/subversion/libsvn_wc/providers.c
>Removed:
> trunk/subversion/libsvn_wc/providers.c
>Modified:
> trunk/subversion/clients/cmdline/main.c
> trunk/subversion/include/svn_client.h
> trunk/subversion/include/svn_config.h
> trunk/subversion/include/svn_wc.h
> trunk/subversion/libsvn_client/ra.c
> trunk/subversion/libsvn_subr/config_file.c
> trunk/subversion/libsvn_subr/config_impl.h
> trunk/subversion/libsvn_wc/README
> trunk/subversion/libsvn_wc/adm_files.c
> trunk/subversion/libsvn_wc/adm_files.h
> trunk/subversion/libsvn_wc/adm_ops.c
>Log:
>
[snip]

>* libsvn_subr/config_file.c (ensure_auth_dirs): new helper function.
>
> (svn_config_ensure): ensure various ~/.subversion/auth/
> subdirectories exist... even if ~/.subversion/ already exists, for
> the sake of smooth upgrades.
>
> (svn_config_read_auth_data, svn_config_write_auth_data,
> auth_file_path): implement new functions.
>

I'd prefer to see this part extracted to a new file, let's say
config_auth.c. I find it confusing to mix code that hanldes config files
and hash dumps. I'd also move ensure_auth_dirs there, even if it's
called from svn_config_ensure.

-- 
Brane ÄŒibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org