[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5553 - trunk/subversion/libsvn_wc

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-04-04 23:43:35 CEST

On Fri, Apr 04, 2003 at 01:36:25PM -0600, sussman@tigris.org wrote:
>...
> +++ trunk/subversion/libsvn_wc/diff.c Fri Apr 4 13:36:25 2003
> @@ -436,6 +436,7 @@
> const char *pristine_copy, *empty_file;
> svn_boolean_t modified;
> enum svn_wc_schedule_t schedule = entry->schedule;
> + svn_boolean_t copied = entry->copied;

Why does this go into a boolean variable? Why not simply test entry->copied
when you need to? The variable seems to imply that it will be, um, variable.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 4 23:40:20 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.