[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: ra_svn + ssh svn commit hangs for a while after printing "Committed revision xxx."

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2003-04-03 18:55:44 CEST

On Thu, 2003-04-03 at 09:17, Timothee Besset wrote:
> It looks like it would be related to ssh waiting for closure of stdout on
> the server's end before it actually exits. Which kills the benefit of
> backgrounding the post-commit operations. Maybe svnserve should forcibly
> close it's stdout when it exits, or something similar?

Well, you can't forcibly close a file descriptor; the child process
already has a handle on it, and you can't take it away.

We could set stdin and stdout close-on-exec at startup time. That poses
two problems: it's not very portable, and it would run the risk that
child processes would open files and have them become stdin and stdout.
(A variant that would solve the second problem is to dup stdin and
stdout and then redirect the originals to /dev/null. Even less portable
to Windows.) This would also solve the "ra_svn over ssh can have its
data stream corrupted by hook scripts" issue.

We could make the post-commit close its stdin and stdout and stderr,
which wouldn't be a terrible idea for something running in the
background. Obviously, that doesn't solve the hook script problem.

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 3 18:56:38 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.