[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5534 - trunk/subversion/tests/clients/cmdline

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-04-03 07:24:54 CEST

kraai@tigris.org wrote:

>Author: kraai
>Date: Wed Apr 2 17:14:54 2003
>New Revision: 5534
>
>Modified:
> trunk/subversion/tests/clients/cmdline/diff_tests.py
>Log:
>* subversion/tests/clients/cmdline/diff_tests.py
> (diff_nonextant_urls): Check all output for error message.
>
>
>Modified: trunk/subversion/tests/clients/cmdline/diff_tests.py
>==============================================================================
>--- trunk/subversion/tests/clients/cmdline/diff_tests.py (original)
>+++ trunk/subversion/tests/clients/cmdline/diff_tests.py Wed Apr 2 17:14:54 2003
>@@ -818,12 +818,18 @@
>
> diff_output, err_output = svntest.main.run_svn(None, 'diff', non_extant_url,
> extant_url)
>- if not re.match('svn: Filesystem has no item$', err_output[0]):
>+ for line in err_output:
>+ if re.match('svn: Filesystem has no item$', line):
>+ break
>+ else:
> raise svntest.Failure
>
> diff_output, err_output = svntest.main.run_svn(None, 'diff', extant_url,
> non_extant_url)
>- if not re.match('svn: Filesystem has no item$', err_output[0]):
>+ for line in err_output:
>+ if re.match('svn: Filesystem has no item$', line):
>+ break
>+ else:
> raise svntest.Failure
>
>

We now have at least 4 such checks in the tests that I know of. Wouldn't
it be time for abstracting them into a function in svntest.actions?

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 3 07:25:43 2003

This is an archived mail posted to the Subversion Dev mailing list.