[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Safe to remove apr_file_flush?

From: Blair Zajac <blair_at_orcaware.com>
Date: 2003-04-02 22:13:28 CEST

I'm looking through the source code looking for FIXME's that can
be removed and I ran into this one in subversion/libsvn_ra_dav/util.c:

svn_error_t *svn_ra_dav__set_neon_body_provider(ne_request *req,
                                                apr_file_t *body_file)
  apr_status_t status;
  apr_finfo_t finfo;

  /* ### APR bug? apr_file_info_get won't always return the correct
         size for buffered files. */
  /* FIXME: This APR bug has been fixed on both Unix and Win32 for the
     0.9.2 release. Remove this flush once that is part of a released
     httpd (presumably 2.0.45). */
  status = apr_file_flush(body_file);
  if (!status)
    status = apr_file_info_get(&finfo, APR_FINFO_SIZE, body_file);

I normally thought this would be safe to remove, but looking through
APR, only the unix and win32 filestat.c call apr_file_flush.

So, I'm wondering if it's safe to remove code in util.c, because the
netware, os2 filestat.c's don't call apr_file_flush.


Blair Zajac <blair@orcaware.com>
Plots of your system's performance - http://www.orcaware.com/orca/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 2 22:14:14 2003

This is an archived mail posted to the Subversion Dev mailing list.