[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: commit comments after failure

From: <kfogel_at_collab.net>
Date: 2003-03-30 21:50:15 CEST

Dan Allen <dan@mojavelinux.com> writes:
> If you run `svn commit`, record a log and then the merge fails
> (because your local copy was not updated), it would be nice if the
> next time you go to commit, it loads up this log so that you don't
> have to retype it or play file king getting the comments back into
> the current log window. Ideally, I believe that the merge check
> should occur before the log is requested so you don't waste time
> writing a log comment when it is just going to fail anyway. Either
> way, it is rather inconvient in the current state of things.

I'm not sure it's worth it to do the merge check before writing the
log message -- things could still get out of date while you're writing
it, after all.

I like the idea of reloading the previous failed message on the retry,
but it's hard for Subversion to know whether the next commit _is_ a
retry or not. Maybe you're committing an entirely different set of
files. Anyway, Subversion keeps no record of how many failed attempts
at commit have happened recently, and I'm not sure it should. Any
time we start recording more state, we're increasing the number of
ways to get into trouble.

In other words, this is a less-than-ideal user experience, but not a
horrible one -- and the solutions seem like more complexity than the
problem is worth. IMHO, of course.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 30 22:31:28 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.