Re: [PATCH] Compressed streams (take 2)

New patch attached.

* Branko ??ibej (brane@xbc.nu) wrote:
> Eric Dorland wrote:
>
> >Alrighty, attached is the compressed stream code with an extra large
> >test case, which will cause the read code to use more than one buffer
> >full of data and also addresses all the other points that were
> >raised. It's kind of a big patch since the test case had to be *big* :)
> >
>
> * Look at libsvn_delta/random-test.c. We generate random bytes there
> and do provide a way to reproduce the test. Don't, and I mean do
> *not*, hard-code "random" bytes in the test, because then you're
> not testing on random data, you're testing on hard-coded data.

Well I could feed random as a test, but I don't think it's really a
worthwhile test. I just wanted a test that was big enough that it
couldn't fit into a single buffer read, just to exercise that code
path. I don't think a random test really buys us anything other than
testing zlib, which has probably been well tested enough at this point :)

> * What's with all the indentation changes in configure.in? 90% of
> your changes there are just indentation. Lose them.

Sorry, I untabified the file. It's got some tabs in there.

> * You're putting tabs in the sources. We don't use tabs in the
> sources. Read HACKING about how our stomachs turn at tabs in the
> sources.

Will do.
 
> * Please don't define the symbol "ZLIB". Instead, use something
> that's namespace-protected; for instance, "SVN_HAVE_ZLIB" or
> something like that would be much better.

Changed the symbol.

> * In the docstring for svn_stream_compressed in svn_io.h, you
> explicitly mention zlib compression. I think the use of ZLIB is an
> implementation detail, and doesn't have to be mentioned in the
> docstring.

Done.

> * Please add a comment about what ZBUFFER_SIZE is for.

Done.

-- 
Eric Dorland <eric.dorland@mail.mcgill.ca>
ICQ: #61138586, Jabber: hooty@jabber.com
1024D/16D970C6 097C 4861 9934 27A0 8E1C  2B0A 61E9 8ECF 16D9 70C6
-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GCS d- s++: a-- C+++ UL+++ P++ L++ E++ W++ N+ o K- w+ 
O? M++ V-- PS+ PE Y+ PGP++ t++ 5++ X+ R tv++ b+++ DI+ D+ 
G e h! r- y+ 
------END GEEK CODE BLOCK------