On Fri, Mar 28, 2003 at 10:52:03PM -0600, kfogel@collab.net wrote:
> By the way, I didn't mean to shut off discussion about the potentially
> controversial portion of Brian Denny's patch: he changes
> svn_path_condense_targets() to handle URLs by treating them as
> absolute paths. He then wondered whether this might be a problem if
> there's a file whose name looks like a URL.
>
> I think this is nothing to worry about. If someone is weird enough to
> name a file "http://foo.bar.baz/qux", they get what they deserve, and
> anyway can work around it by saying "./http://foo...".
If anyone is inclined to chime in on this, you might also consider
whether svn_path_get_absolute and svn_path_get_longest_ancestor
should also have special handling for URLs.
The handling i have in mind is:
svn_path_get_absolute: if given an URL, just return the same (or a
copy of) URL.
svn_path_get_longest_ancestor: if given two URLs whose longest common
prefix is "protocol://", they have no
common ancestor.
Currently i'm using private (to target.c) helper functions which wrap the
above functions, but i'm tempted to fold this functionality into the
library functions.
opinions?
-brian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Mar 29 08:41:39 2003