Re: Issue #1108 questions

Brian Denny <brian@briandenny.net> writes:

> I'm working on #1108.
>
> I have a few questions (with reference to the draft patch below):
>
> - 'http://foo/bar' isn't a valid path on UNIX,

That's a valid Unix path. The Subversion command line client will
generally interpret it as an URL, unless you prepend "./" to it. It
might be a valid path in the Subversion filesystem, but I'm not sure
about the "//".

> but what about other
> platforms? i.e., is it okay for path functions to handle URLs?

I don't understand the question.

> (in the patch below, 'svn_path_condense_targets' does not try to
> convert a target to an absolute path if it appears to be an URL.
> is this un-smurfy?)
>
> - *if* it's okay for path functions to handle URLs, then should
> the functionality of the new function 'get_absolute_path_or_url'
> just be folded into 'svn_path_get_absolute'
>
> - am i correct in thinking that i need to open and close an adm_access
> baton once for each target (given that i need to get each target's
> wc entry, and i can't assume a common basepath)?

You need an adm_access baton to get a wc entry. Whether you reuse
them is up to you.

> (the following patch still lacks some comments, tests, and a log message,
> but preliminary tests indicate that it resolves the issue.)

You don't say what issue 1108 is about and you don't provide a log
message, that makes it much harder to answer your questions.

I've looked over the patch but I can't determine which problem you are
trying to solve, perhaps I need to go and look up that issue...

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org