Re: svndumpfilter - rfc.

Philip Martin wrote:
> Alexander Sabourenkov <screwdriver@lxnt.info> writes:

[...]

> This email was prompted by recent svndumpfilter emails, is the above
> URL the most recent patch? Personally, I find inline patches the
> easiest to review, external URLs the hardest, and attachments
> somewhere in between.

Ok, I'll post an updated patch here in several hours.

> The man page (Documentation!) still refers to --exclude and --include.

There was a discussing here some timeago that man pages are obsolete and
should go away in favor of 'help' subcommand and The Definitive Guide.

There isn't that much to document, so I think I'd drop the man page.

>>Should parser recalculate & verify MD5 sums?
>>(it now just passes them through intact)
>
>
> I think it should just pass them through.

Again, there was a request for 'svnadmin verify'. I'll look into it and
if it is trivial to implement I'll do it.

> Do you mean
> a) drop the copyfrom history but retain the node
> b) drop the node?
>
> I think b) would make more sense.

It is b).

[ ... ]

>
>
> There are arguments for and against renumbering, ideally the user
> would be able to choose.

so be it.

> Do you think this is ready to commit? Do you have an up-to-date
> patch? Regression tests would be nice, although not strictly
> necessary.

Will be ready to commit in several hours.
I'll try to write some regression tests after that. Test suite is a
whole new chunk of code to learn.

-- 
./lxnt
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org