Re: Dodgy ssl code

Philip Martin <philip@codematters.co.uk> writes:

> The functions server_ssl_callback, client_ssl_keypw_callback,
> client_ssl_callback in libsvn_ra_dav/session.c don't handle errors
> properly.

Philip, you are so correct. Thank you for noticing.

David Waite, can you fix this in your upcoming patch? Please trap the
svn_error_t's thrown by the svn_auth_* calls, and clear them, and
throw -1. See session.c:request_auth() for an example.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Mar 27 01:53:09 2003