Re: svn commit: rev 5449 - trunk/subversion/tests/clients/cmdline

On Tue, Mar 25, 2003 at 12:01:37PM -0800, Daniel Rall wrote:
> Karl Fogel <kfogel@newton.ch.collab.net> writes:
>
> > Ben Collins-Sussman <sussman@collab.net> writes:
> > > 1. look for a sentence or paragraph that explains what the change is
> > > about.
> > >
> > > 2. if still interested, read about the symbols changed.
> > >
> > > 3. if still interested, read the diffs.
> >
> > I should confess that I've written log message like Matt's before,
> > too, so I hope I don't sound *too* preachy :-).

Oh, yah... we all have :-) I think Matt's is just a handy focal point for
this discussion, rather than an "everybody pick on Matt" thread :-)

> > However, I'm now
> > trying to always write a summary blurb, the only exceptions being when
> > there's just one place changed -- then the blurb and the technical
> > description are one and the same.
>
> The "what" of a change is important (and the change to the example log
> message is an improvement), but once I'm at least casually familiar
> with a body of code, I find the "why" a lot more important.

Right. And I'll note your svn_config stuff started with one line:

Log:
http://subversion.tigris.org/issues/show_bug.cgi?id=1165

* subversion/libsvn_subr/config_impl.h
...

The message has since been corrected... :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org