Re: svn commit: rev 5449 - trunk/subversion/tests/clients/cmdline

Matt Kraai <kraai@alumni.cmu.edu> writes:
> > Again, please please please write more than "fixed issue N". Now I
> > have to go look up this issue in the database to even know what it's
> > about. :-) A single sentence would suffice:
> >
> > "Fix issue #1193: don't use os.path.join in python tests"
>
> The next lines were
>
> * subversion/tests/clients/cmdline/basic_tests.py
> (basic_checkout, basic_switch, basic_checkout_deleted): Use string
> concatenation instead of os.path.join to construct URLs.

I still think Ben's advice is good... But the change was pretty easy
to identify anyway, because it was fully described in the first entry,
and then subsequent entries just said "Likewise."

A borderline case.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 25 20:11:36 2003