Re: [1165 PATCH] Request for review of basic expansion

=?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@xbc.nu> writes:

> Daniel Rall wrote:
>
> >+ /* ### Rewriting this function using full-blown tokenization
> >+ ### would prevent attempted expansions of text like
> >+ ### "%(foo %(bar)s" under the name of "foo %(bar". */
> >
>
> That's quite all right. "foo %{bar" is a valid option name. :-)
>
> Sequences like this this could obviously be typos; but, since we leave
> the whole placeholder in the value if we can't expand it, they're also
> easily debuggable.
>
> All in all, this patch looks beautiful. Commit, commit!

Thanks Brane, committed as r5444.

-- 
Daniel Rall <dlr@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org