[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5399 - trunk/subversion/tests/clients/cmdline/svntest

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-03-23 22:37:16 CET

B. W. Fitzpatrick wrote:

>>brane@xbc.nu writes:
>>fitz@tigris.org wrote:
>>
>>
>>
>>>* subversion/tests/clients/cmdline/svntest/main.py: Move SVNTree*
>>> Exception classes out. Convert comments to docstrings on remaining
>>> Exception classes, and remove unnecessary __init__ declarations.
>>>
>>>
>>>
>>What do you mean, unnecessary? You've changed the behaviour of those
>>classes. Before, if you threw an SVNTreeUnequal exception, you'd get the
>>following in the test output:
>>
>> EXCEPTION: svntest.main.SVNTreeUnequal
>>
>>Now, you'll get nothing.
>>
>>A bit of history: We used to explicitly check for SVNTreeUnequal in
>>TestCase::run, print something, and convert it to an error code. Now, we
>>only catch svntest.Failure, and print out the message it contains (if
>>any): I defined __init__ in the SVNTree* classes that way so that we
>>still print something for non-generic exceptions.
>>
>>
>
>Oy. I'll revert the change, but before I do, I'd like for gstein to
>respond to this--he said it was unnecessary and I'm not that familiar
>with the intricacies of exception handling in Python.
>
>

Sure, the __init__ definitions arent *necessary*, but they preserve
behaviour we used to have. If people decide we don't need that behaviour
-- fine. I'd just point out that we don't print a stack trace when we
catch those exceptions, so printing the exception type might be nice.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Mar 23 22:37:57 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.