Re: svn commit: rev 5399 - trunk/subversion/tests/clients/cmdline/svntest

fitz@tigris.org wrote:

>* subversion/tests/clients/cmdline/svntest/main.py: Move SVNTree*
> Exception classes out. Convert comments to docstrings on remaining
> Exception classes, and remove unnecessary __init__ declarations.
>
What do you mean, unnecessary? You've changed the behaviour of those
classes. Before, if you threw an SVNTreeUnequal exception, you'd get the
following in the test output:

    EXCEPTION: svntest.main.SVNTreeUnequal

Now, you'll get nothing.

A bit of history: We used to explicitly check for SVNTreeUnequal in
TestCase::run, print something, and convert it to an error code. Now, we
only catch svntest.Failure, and print out the message it contains (if
any): I defined __init__ in the SVNTree* classes that way so that we
still print something for non-generic exceptions.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org