Re: [PATCH] non static libs on windows (dll)

mbk@boredom.org wrote:

>On Sat, Mar 22, 2003 at 06:14:46PM -0500, Garrett Rooney wrote:
>
>
>>On Saturday, March 22, 2003, at 06:10 PM, Russell Yanofsky wrote:
>>
>>
>>
>>>>4) Exported data structures should never contain an enum type. An
>>>>int or similar type is far superior.
>>>>
>>>>
>>>Yes. I don't know whether subversion does this.
>>>
>>>
>>not being a windows person, i have no idea why using enumerated types
>>would be a problem. what exactly is the issue with this? i've always
>>been told to prefer enums for reasons of type safety.
>>
>>-garrett
>>
>>
>>
>
>Some compilers generate smaller-than-int storage allocations for enums
>with less than MAXINT values. They then proceed to, for example, char
>align them. This can cause headaches.
>
>

I couldn't care less about compilers that don't follow the system's ABI.
On Windows, VC++ sets the (C) ABI [1], and other compilers have to
follow that. We're not going to support noncompliant compilers.

[1] Note that I'm not talking about C++ here, just C

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org