[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Segfault when comitting property changes on wc root

From: Vladimir Prus <ghost_at_cs.msu.su>
Date: 2003-03-21 16:13:35 CET

Hi,
I've just got segfault from svn when trying to comit after setting
"svn:externals" on wc root. The reproduction recipe is attached,
and the patch is below.

Log message:
Fix segfault on comitting changes to wc root.

* subversion/clients/cmdline/util.c
   (svn_cl__get_log_message): Set 'path' to "." for wc root, not to NULL.

Patch:
Index: subversion/clients/cmdline/util.c
===================================================================
--- subversion/clients/cmdline/util.c (revision 5418)
+++ subversion/clients/cmdline/util.c (working copy)
@@ -467,6 +467,8 @@
           if (path && lmb->base_dir)
             {
               path = svn_path_is_child(lmb->base_dir, path, pool);
+ if (! path)
+ path = ".";
             }
 
           if ((item->state_flags & SVN_CLIENT_COMMIT_ITEM_DELETE)

- Volodya

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Fri Mar 21 16:14:48 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.