[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5374 - in trunk/subversion: clients/cmdline tests/clients/cmdline

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-03-19 01:34:28 CET

cmpilato@tigris.org wrote:

>Author: cmpilato
>Date: Tue Mar 18 12:10:34 2003
>New Revision: 5374
>
>Modified:
> trunk/subversion/clients/cmdline/main.c
> trunk/subversion/clients/cmdline/propget-cmd.c
> trunk/subversion/tests/clients/cmdline/prop_tests.py
>Log:
>Add a --strict option to 'svn propget', and get some binary property
>testing in place.
>
>* svn-debug/subversion/clients/cmdline/main.c
> (svn_cl__cmd_table): Add the --strict option to propget, and
> describe that subcommand's output a little better. Also, clean up
> some other usage strings that ended in double-newlines (we only
> need one at the end of usage strings)
>
>* svn-debug/subversion/clients/cmdline/propget-cmd.c
> (stream_write): New helper.
> (svn_cl__propget): Use binary streams for output, and handle --strict.
>
>* svn-debug/subversion/tests/clients/cmdline/prop_tests.py
> (check_prop): Move this helper into the global context, and make it
> use --strict so that newlines aren't appended to the property values.
> (prop_value_conversion): check_prop() is now global, and we don't
> need the extra newlines on the property values now.
> (binary_props): New test.
> (test_list): Add binary_props() which currently doesn't run over DAV.
>

Hm! here's what happens on the Windows tests now:

CMD: svn.exe "pg" "--strict" "svn:ignore" "working_copies/prop_tests-12/A" <TIME = 0.079000>
svn pg --strict svn:ignore output does not match expected.
Expected standard output: ['*.o\r\n', 'foo.c\r\n']

Actual standard output: ['*.o\n', 'foo.c\n']

FAIL: prop_tests.py 12: some svn: properties should be converted

I thought that we always converted multiline props to the correct locale
and native EOLN format on output? I think we're missing a conversion here.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Mar 19 01:37:13 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.