Re: svn commit: rev 5378 - trunk/subversion/tests/clients/cmdline

On Tue, Mar 18, 2003 at 11:46:16PM +0100, Branko Cibej wrote:
> Greg Stein wrote:
>...
> >Note that you would want to create subclasses of svntest.Failure for this
> >stuff to raise. For example:
> >
> > class DifferentTrees(svntest.Failure):
> > pass
> > ### or maybe some detailed info about how they are different, which
> > ### can then be reported as part of the exception handling
>
> Or just use SVNTreeUnequal.

Yah. I didn't see that one until later. But the concept of creating custom
subclasses was the important point here.

>...
> >>@@ -741,14 +730,12 @@
> >> out, err = svntest.main.run_svn(None, 'propset', '--revprop', '-r', '0',
> >> 'cash-sound', 'cha-ching!', sbox.wc_dir)
> >> if err:
> >>- return 1
> >>+ raise svntest.Failure
> >
> >I think that we want a run_svn() variant that raises exception if anything
> >is ever produced on stderr. Maybe run_svn_noerr().
>
> Yup, I said much the same thing.

:-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org