Re: [Issue 639] - introduce svn_filesize_t

On Tue, 2003-03-18 at 17:39, Branko Èibej wrote:
> I think we wouldn't get this far if the FS is corrupt. The only way I
> can imagine this happening is if SVN_STREAM_CHUNK_SIZE >=
> SVN_MAX_OBJECT_SIZE, which should never happen. I put in the second
> assert as an extra check to make sure that the cast to apr_size_t
> doesn't lose data.

Okay. As long as they're assertions about code invariants and not file
invariants, that's fine.

> >I didn't see any other potential problems in my read-through.
> >
> >
> These are potential problems?

Well, potentially. :) It's not okay to use assert() when checking the
consistency of on-disk data, because the Subversion code should never
ever abort in the absence of bugs. But it sounds like that's not an
issue here.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 18 23:45:50 2003