[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn:original-date (was: svn commit: rev 5369 - trunk/subversion/include)

From: Benjamin Pflugmann <benjamin-svn-dev_at_pflugmann.de>
Date: 2003-03-18 10:36:23 CET

On Mon 2003-03-17 at 23:36:35 -0800, Greg Stein wrote:
> > Modified: trunk/subversion/include/svn_props.h
> > ==============================================================================
> > --- trunk/subversion/include/svn_props.h (original)
> > +++ trunk/subversion/include/svn_props.h Tue Mar 18 00:34:02 2003
> > @@ -256,6 +256,19 @@
> > /** The fs revision property that stores a commit's date. */
> > #define SVN_PROP_REVISION_DATE SVN_PROP_PREFIX "date"
> >
> > +/** The fs revision property that stores a commit's "original" date.
> > + *
> > + * The svn:date property must be monotonically increasing, along with

Just minor nitpicking: Intentionally, I read this comment before
your explaining words in the main body of the mail, and could not
make much sense of it. The reason was that I did not notice that you
referenced the behaviour of svn:date, while this comment is about
svn:original-date, despite re-reading it serveral times. At least,
until I read the rest of your mail.

How about a rewording. Something like "svn:original-date is meant to
be suplementary to the svn:date property, which must be..." - surely
not ideal, but you get the idea.

> > + * the revision number. In certain scenarios, this may pose a problem
> > + * when the revision represents a commit that occurred at a time which
> > + * does not fit within the sequencing required for svn:date. This can
> > + * happen, for instance, when the revision represents a commit to a
> > + * foreign version control system, or possibly when two Subversion
> > + * repositories are combined. This property can be used to record the
> > + * true, original date of the commit.
> > + */

HTH,

        Benjamin.

  • application/pgp-signature attachment: stored
Received on Tue Mar 18 10:38:06 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.