Re: svn commit: rev 5322 - in trunk/subversion: include libsvn_subr
From: Greg Stein <gstein_at_lyra.org>
Date: 2003-03-14 12:08:56 CET
On Fri, Mar 14, 2003 at 12:19:29AM -0600, cmpilato@tigris.org wrote:
We tweaked the doxygen configuration. You no longer need to repeat the
> +++ trunk/subversion/libsvn_subr/xml.c Fri Mar 14 00:19:06 2003
092?? Maybe 192... :-)
>...
Personally, I find this backwards. "end" is the invariant, so listing it
while (p++ < end)
But whichever way you choose it, the code is incorrect. You never end up
for (p = data; p < end; ++p)
You could also use "while (p < end)" and put the post-increment in the test,
Cheers,
-- Greg Stein, http://www.lyra.org/ --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org For additional commands, e-mail: dev-help@subversion.tigris.orgReceived on Fri Mar 14 12:07:32 2003 |
This is an archived mail posted to the Subversion Dev mailing list.
This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.