Re: revprop change notifications (was: svn commit: rev 5289 ...)

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> There's no reason for the pre-revprop hook to take the value as a
> tempfile -- it can get the value from the Subversion txn as many times
> as it wants.

True, true. I thought we were taking it on STDIN, since that's what
the pre-revprop-change hook template claims >:-(.

> There is some argument for using a tempfile for the post-revprop
> hook, but that also opens up the whole "What happens if no one
> cleans up the file?" question, as well as unintuitively involving
> two hook scripts in what most people would imagine is a
> one-hook-script problem.

No, actually, it doesn't open that question. The repos layer is
required to clean up that file. How hard is that?

> IMHO, stdin is a *much* cleaner solution; I'm implementing it now.

STDIN is also much more limited; please reconsider.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 14 06:26:54 2003