Re: revprop change notifications (was: svn commit: rev 5289 ...)

Greg Stein <gstein@lyra.org> writes:

> That would work, as long as SVN was doing it. I was thinking about the case
> where the pre- creates a tempfile, hoping that the post- would read it.
>
> I hope that we wouldn't have to use a tempfile, but we might have to, to
> deal properly with binary properties. Some shells/scripting languages might
> not deal very well with binary on stdin.

Hm...the more I think about it, the more I prefer the tempfile thing.
By using a tempfile, we give scripts the ability to read
non-streamily, or to read the value more than once. This might
initially sound like a bad thing, but consider a script which must
first example the property to determine if it is binary or not, and
might choose a different 'diff' program based on the results.

In fact, if we change the pre-revprop-change hook to also take the
tempfile, then we can now write the old property value only once --
and post pre- and post- hooks can read from the same file. Might as
well make the new property value live in a tempfile, too.

Whatever, hands are running faster than my mind right now, so perhaps
this is all rubbish.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Mar 14 05:41:33 2003