Re: [PATCH] Re: propedit on svn:mime-type

Alex Waugh wrote:

>In message <3E6D279B.4060604@xbc.nu>
> Branko Cibej <brane@xbc.nu> wrote:
>
>
>
>>As you see, I already committed your patch. Could you update and then
>>post a new patch for just the tests? Thanks!
>>
>>
>
>
>* subversion/tests/clients/cmdline/prop_tests.py
> (strip_or_add_whitespace): More tests for whitespace stripping and forcing
> svn:executable.
>
[snip]

>+ # svn:executable value should be forced to a '*'
>+ set_prop('svn:executable', 'foo', iota_path)
>+ set_prop('svn:executable', '', lambda_path)
>+ set_prop('svn:executable', ' ', mu_path)
>
Heh, don't you thing you should call the test something other than
"strip_or_add_whitespace", if you're testing the svn:executable
conversion? I'd suggest "prop_value_conversions", and change the docstring.

>+ # Anything else should be untouched
>+ set_prop('svn:foo', 'bar', lambda_path)
>+ set_prop('svn:foo', ' bar baz', mu_path)
>+ set_prop('svn:foo', 'bar\n', iota_path)
>
Don't call it "svn:foo", just "foo". The "svn:" namespace is reserved
for well-known properties (although we're not pedantic about them, and
the values _do_ get treated as UTF-8 text with native newlines. I think.

So, just "foo" is better. Or "some-prop"; foo is way overused.

The rest is fine; I'll commit if you can fix these nits.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org