Re: svnserve and tunneling over ssh (Matt Kraai take notice)

On Tue, 2003-03-11 at 11:54, Jeff Putsch wrote:
> The command executes but never exits.

I see this too. This bug was apparently introduced in rev 5217 (March
6) by Matt Kraai. There used to be an explicit close handler in the RA
layer, but now it's handled through pool cleanups. It appears that the
process cleanup handler is running before the file cleanup handlers for
the pipe, and the only thing making the ssh process exit was that its
input pipe was closed. (It also appears that the pipes aren't being
closed in the child process before ssh is exec'd, which the child
cleanup handlers were supposed to take care of; that needs more
investigation.)

Two other problems with that change: the process cleanup registration
overflows 80 columns, and the comment wasn't changed to reflect the new
purpose of the code.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 11 18:17:44 2003