Re: certs review

David Waite <mass@akuma.org> writes:

> > (client_ssl_keypw_callback, client_ssl_callback): whoa, tex... you
> > never check the error return value from
> > svn_auth_first_credentials(). Why not just wrap the call in the
> > SVN_ERR() macro? And in client_ssl_callback, you're dereffing
> > credentials when it may be NULL! Also, these funcs could use short
> > docstrings.
> >
> We'll need to talk about this more - I cannot return a svn_error_t*
> outright, and some of these providers simply cannot retry

Ah, right. I forgot that this is inside a neon callback. Hmmm.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 11 17:30:38 2003