Re: svn commit: rev 5259 - trunk/subversion/libsvn_ra_dav

Greg Stein <gstein@lyra.org> writes:

> > Why not just like so?
> >
> > apr_hash_set (hash, apr_pstrdup (apr_hash_pool_get (hash), path),
> > APR_HASH_KEY_STRING, &kind);
>
> Right. That approach saves an svn_string_t from the heap. It does a bit of
> extra length counting, but if that is a problem:

Right. I used that approach to save a strlen()...

> apr_size_t len = strlen(path);
>
> path = apr_pstrmemdup(apr_hash_pool_get(hash), path, len);
> apr_hash_set(hash, path, len, &kind);

...because I forgot about apr_pstrmemdup(). :-(

> Woah!! This whole valid_targets thing is way busted, and has been for a long
> while. Dang... we've just been lucky. First, we had bad path lifetimes,
> which Mike fixed. But we *still* have problems with that kind.

Yah, I don't think it even gets used anymore. My recollection is that
it was stuff for the MERGE response handling, which is currently
disabled. I just happened to notice the pool problem while doing
other things.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Mar 11 06:38:05 2003