Re: svn commit: rev 5253 - in trunk: build subversion/tests/libsvn_subr

Daniel Rall wrote:

>Judging by Brane's commits, the config-test.cfg file couldn't be found
>in some build setups. Having successfully run the config-test binary
>from within my source tree and watched `make check` pass, I'm a bit
>put off that I never experienced this problem myself. Any advice
>which would help me avoid introducing this sort of badness in the
>future (i.e. how did you guys trigger the test failure)?
>
You were doing in-tree builds and tests. The problem turns up in VPATH
builds -- i..e, when objdir != srcdir. Your test config file lives in
the sources, not in the object tree, and the test didn't account for that.

What you want to do to catch these kinds of errors is, for example:

    svn co http://svn.collab.net/repos/svn/trunk repo
    mkdir obj
    cd repo && ./autogen.sh
    cd ../obj && ../repo/configure ....
    make
    make check
    *BOOM*

(The *BOOM* is optional, it only happens if you hosed the tests :-)

It's also a good idea to follow the svn-breakage mailing list. My
otherwise stable tests on Debian Woody and Solaris 2.6 started failing
after that test was added.

>Brane, thanks for fixing.
>
No problem.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org