Re: [PATCH] Re: propedit on svn:mime-type

Branko ÄŒibej <brane@xbc.nu> wrote:
> Ah, one more I missed:
>
> Alex Waugh wrote:
>
> >+ else if (strcmp (name, SVN_PROP_IGNORE) == 0
> >+ || strcmp (name, SVN_PROP_EXTERNALS) == 0)
> >+ {
> >+ new_value = svn_stringbuf_create_from_string (value, pool);
> >+ /* Make sure that the last line ends in a newline */
> >+ if (new_value->data[new_value->len - 1] != '\n')
> >+ svn_stringbuf_appendbytes (new_value, "\n", sizeof ("\n"));
> >+ }
> >
> You're adding one character, but sizeof("\n") is 2, not 1 (remember the
> nul terminator, right?)

I thought that sizeof("\n") == sizeof(char*).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 10 17:36:42 2003