Re: [PATCH] Re: propedit on svn:mime-type

Quoting Alex Waugh <alex@alexwaugh.com>:

> - SVN_ERR (svn_io_set_file_executable (path, TRUE, TRUE, pool));
> + {
> + /* Since we only check if the property exists or not, force the
> + property value to a specific value */
> + new_value = svn_stringbuf_create_from_string (value, pool);
> + svn_stringbuf_set (new_value, SVN_PROP_EXECUTABLE_VALUE);
> + SVN_ERR (svn_io_set_file_executable (path, TRUE, TRUE, pool));
> + }

How about just:

    value = SVN_PROP_EXECUTABLE_VALUE;

You don't have to create a stringbuf just to change the prop value to a fixed
string, right? :-)

And because of the prop name test above, you do know that new_value will be null
if you got that far, so there's no danger of new_value overriding value later on.

I'll make that change and commit later today.

    Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Mar 10 14:42:02 2003