Re: svn commit: rev 5251 - trunk

On Sun, Mar 09, 2003 at 11:37:38AM -0600, jerenkrantz@tigris.org wrote:
> Author: jerenkrantz
> Date: Sun Mar 9 11:37:36 2003
> New Revision: 5251
>
> Modified:
> trunk/Makefile.in
> trunk/configure.in
> Log:
> Add an --experimental-libtool option to configure to use whatever libtool
> APR is using instead of building our own libtool.
>
> This is useful for jlibtool users or anyone who knows that APR's libtool is
> sufficient (i.e. libtool >1.4).

But it isn't useful if APR's was configured with --disable-shared, yet you
want that for SVN. Or vice-versa. There are other libtool configuration
flags which you may want to use with SVN (e.g. --enable-all-static) that
would *never* be done with APR.

And the user who is configuring SVN isn't going to really know about these
dependencies.

I'm alright with using something like jlibtool as a substitute, but I don't
think that we should ever tie our "libtool" configuration to another
package's configuration.

>...
> +++ trunk/configure.in Sun Mar 9 11:37:36 2003
> @@ -157,12 +157,29 @@
> dnl Look for a C compiler
> AC_PROG_CC
>
> +dnl Look for a C pre-processor
> +AC_PROG_CPP
> +
> +dnl Look for an extended grep
> +AC_PROG_EGREP

What are these for? You didn't add anything that used these. Were we already
using these features, but forget to do the AC_PROG_* thing?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org