[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [Issue 1019] Changed - don't run diff on binary files

From: Sander Striker <striker_at_apache.org>
Date: 2003-03-04 20:42:24 CET

> From: Karl Fogel [mailto:kfogel@newton.ch.collab.net]
> Sent: Tuesday, March 04, 2003 7:09 PM

> "Sander Striker" <striker@apache.org> writes:
>> I'm not so sure it is smart to move this particular one back. We now
>> get very clunky output when you try to diff binary files (since we try
>> to do that as if it were text).
>
> Would you have time to fix it sooner?

I was kindof hoping it would be a quick fix, but it probably isn't. Attached
patch is a first stab at the problem.

Philip, could you please take a look at the attached patch. It's segfaulting
in svn_wc_adm_retrieve, probably because I am forgetting to initialize something.

*grunt*, WC - WC, URL - WC, WC - URL, URL - URL, can we even get
svn_wc_adm_access_t's for all of those cases?

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue Mar 4 20:43:11 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.