On Sun, Mar 02, 2003 at 10:46:16PM +0100, Branko ??ibej wrote:
> Gareth McCaughan wrote:
>
> >Suppose you have a property on a file that's something other than
> >plain text: a thumbnail image, perhaps. Then to edit it you have to
> >use "svn propget" and "svn propset"; you can't just use "svn
> >propedit".
> >
> >Imagine that "svn propedit" takes a command-line option called
> >"--editor-cmd", which specifies what external editor is to be called
> >to edit the property. Then you can say
> >
> > svn propedit thumbnail whatever-file --editor-cmd image-editor
You could also do: SVN_EDITOR=image-editor svn propedit thumbnal whatever-file
> >
> >or some variant thereof that actually works for your image file.
> >I claim this would be a good thing, so I've implemented it; the
> >attached diffs do what's needed. (Attached because the last
> >time I sent a patch my mailer mangled it.)
> >
> >Comments?
> >
> It feels like the command-line client is slowly transmogrifying into a
> full-blown GUI...but maybe that's just me. Apart from that, I don't see
> anything wrong with the idea.
>
> >There was one decision that troubled me. Should the command-line
> >option be called "--editor-cmd" (which might be useful for other
> >Subversion subcommands in the future), or something more specific
> >like "--property-editor-command"?
> >
> Our policy is to make the option names as generic as possible (and
> sane). There's no reason not to use --editor-cmd for other purposes, not
> just svn propedit. On that note...
>
> >+ {"editor-cmd", svn_cl__editor_cmd_opt, 1,
> >+ "Use \"ARG\" as external editor for all but log msgs"},
> >
> Why "for all but log msgs?" There's no reason why "svn commit", and
> other commands that accept an -m or -F for log messages, shouldn't
> accept --editor-cmd, too.
>
> --
> Brane ??ibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson http://www.pilch-bisson.net
"Historically speaking, the presences of wheels in Unix
has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- application/pgp-signature attachment: stored
Received on Mon Mar 3 18:05:45 2003