[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] NULL-handling problem with libsvn_subr/config

From: Marcus Comstedt <marcus_at_mc.pp.se>
Date: 2003-02-28 16:45:46 CET

cmpilato@collab.net writes:

> I'm *sure* you meant:
> if (cfg)
> {
> /* Canonicalize ...

Yes. I actually carefully wrote it like that at first, but in
svn_config_find_group. But when I moved the check down to find_option
in order to maximize the number of birds my stone would kill, I forgot
to add the extra whitespace...

> Check your formatting here, too. SVN_CONFIG_SECTION_GROUPS looks like
> it should be shifted one column to the right.

That, on the other hand, is an optical illusion caused by TABs. The
indentation becomes correct if you apply the patch (unless you do
TAB->space conversion on the patch first).

  // Marcus

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 28 16:49:21 2003

This is an archived mail posted to the Subversion Dev mailing list.