[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5147 - trunk/subversion/libsvn_fs

From: <cmpilato_at_collab.net>
Date: 2003-02-28 16:09:00 CET

Greg Stein <gstein@lyra.org> writes:

> On Thu, Feb 27, 2003 at 11:13:33PM -0600, cmpilato@tigris.org wrote:
> >...
> > +++ trunk/subversion/libsvn_fs/tree.c Thu Feb 27 23:13:09 2003
> >...
> > +/* Deltify ID's predecessor iff ID is mutable under TXN_ID in FS. If
> > + ID is a mutable directory, recurse. Do this as part of TRAIL. */
> > +static svn_error_t *
> > +deltify_mutable (svn_fs_t *fs,
>
> That comment doesn't match the function.

   [well-considered demolition of my commit removed]

> In short, if there were a couple little txn_body functions to fetch dir
> entries and to fetch nodes-by-id, then this function could be tricked up
> quite nicely. I bet those new txn_body functions could be helpful elsewhere
> to optimize their operation [but that's a guess; I haven't looked].
>
> Overall, it looks like we'd save one trail-operation by avoiding a call to
> svn_fs_is_dir(). An initial view would also say one operation for the
> svn_fs_node_id() call, but we lose that in fetching the dag_node in the
> recursion loop.
>
> What do you think?

I think: sounds wonderful, but I'm tired of switching my working copy
back and forth between trunk and the fs-schema-changes branch, having
already twice self-interrupted to fix this bug. :-) The bug fixed,
this now falls out of my high-priority list.

Would someone else be interested/willing in making the changes that
Greg suggests? Volunteers looking to get their hands dirty with some
filesystem code?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 28 16:10:15 2003

This is an archived mail posted to the Subversion Dev mailing list.