[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: rev 5136 - trunk/subversion/libsvn_fs

From: Sander Striker <striker_at_apache.org>
Date: 2003-02-28 09:48:25 CET

> From: sussman@tigris.org [mailto:sussman@tigris.org]
> Sent: Thursday, February 27, 2003 8:41 PM

> New Revision: 5136
>
> Modified:
> trunk/subversion/libsvn_fs/reps-strings.c
> Log:
>
> A fix for Sander's checksum caching patch (r4908), which itself was a
> rewrite of the original r4882 fix.
>
> * reps-strings.c (struct rep_write_baton): add a 'finalized' boolean,
> indicating if we've final digest cache has been filled in yet.
>
> (rep_write_close_contents): use the flag, so we don't repeatedly
> finalize the md5_context. (Finalizing destroys the context.)

I really, really don't get this. Are you saying that rep_write_close_contents()
is being called multiple times on retry?! I thought only
txn_body_write_close_rep() was being called repeatedly on retry. Something
else seems broken here.

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 28 09:49:12 2003

This is an archived mail posted to the Subversion Dev mailing list.