[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Rcsparse.py

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-02-28 03:13:39 CET

On Thu, Feb 27, 2003 at 01:59:23PM -0600, Karl Fogel wrote:
> Marshall White <cscidork@yahoo.com> writes:
> > Another message in that thread has a potential patch to fix it.
> >
> > In the current bindings SOME functions that have "const char **"
> > parameters return Pythong string objects and some do not (they
> > return that *_p_char crap instead). From the digging around I did,
> > it looked like they ALL should work the same way. That was what my
> > patch did.

Right. 'const char **' should return a Python string object (or None if the
value is NULL). It looks like all the bindings in svn_fs are returning the
_p_char crap.

svn_string.i defines the return stuff for 'const char **', so I'm guessing
that if we just eliminate the type from the OUTPARAM stuff in svn_fs.i,
that all the string returns will just start working.

Hmm. A bit more than that, but I've got it all patched up now.

Committed this and the commit_txn thing in rev 5143.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 28 03:08:56 2003

This is an archived mail posted to the Subversion Dev mailing list.