[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] make mod_dav_svn leak a little less

From: Justin Erenkrantz <jerenkrantz_at_apache.org>
Date: 2003-02-27 18:09:12 CET

--On Thursday, February 27, 2003 6:04 PM +0100 Robert Pluim
<rpluim@bigfoot.com> wrote:

> - return apr_psprintf(resource->pool, "\"%" SVN_REVNUM_T_FMT "/%s\"",
> + return apr_psprintf(p, "\"%" SVN_REVNUM_T_FMT "/%s\"",
> created_rev,
> - apr_xml_quote_string(resource->pool,
> + apr_xml_quote_string(p,
> resource->info->repos_path, 1));

This may be bogus because resource->info->pool may be cleaned up before the
response is written. The test suite has no coverage over any of the lifetime
issues and probably wouldn't check the ETag value for corruption. -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 27 18:09:54 2003

This is an archived mail posted to the Subversion Dev mailing list.