Re: svn commit: rev 5119 - in trunk/subversion: svnadmin include libsvn_fs tests tests/libsvn_fs tests/clients/cmdline/svntest libsvn_repos

Philip Martin <philip@codematters.co.uk> writes:

> Now that I think about it, there is very little to choose between the
> two approaches. At the moment the hash keys are part of the public
> interface. We could have type safety by replacing
>
> #define SVN_AUTH_PARAM_FOO SVN_AUTH_PARAM_PREFIX "foo"
>
> with
>
> void svn_auth_param_set_foo(apr_hash_t *hash, const char *);
> const char * svn_auth_param_get_foo(apr_hash_t *hash);
>
> Then it's a small step to
>
> typedef struct svn_auth_parameters_t svn_auth_parameters_t;
>
> void svn_auth_param_set_foo(svn_auth_parameters_t *params, const char *);
> const char * svn_auth_param_get_foo(const svn_auth_parameters_t *params);

I think you're right. A big C structure with accessors is the way to
go, instead of the hash. No API breakage, and we get type safety to
boot.

Gstein, are there any obvious reasons to stick with the hash?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 27 04:44:56 2003