[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5119 - in trunk/subversion: svnadmin include libsvn_fs tests tests/libsvn_fs tests/clients/cmdline/svntest libsvn_repos

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2003-02-27 06:05:50 CET

Philip Martin <philip@codematters.co.uk> writes:

> Ben Collins-Sussman <sussman@collab.net> writes:
>
> > Alas, I think your dream of putting the realm-data directly into the
> > provider's baton will never work. It would mean that a pointer to the
> > provider baton would somehow have to be propogated all the way down
> > through code, probably to some RA layer receiving the auth challenge.
> > We don't want to propogate every provider baton into RA code!
>
> If I look at request_auth in libsvn_ra_dav/session.c it calls the
> functions svn_auth_first_credentials and svn_auth_next_credentials.
> Those functions in turn call svn_auth_provider_t's first_credentials
> and next_credentials, and first_credentials *already* gets passed a
> provider_baton parameter. Is that not a provider specific baton?

Yes, but ra_dav has no access to provider batons. It has no access to
the providers whatsover, only the auth_baton. svn_auth.h *hides*
providers from the core svn code; the public API only allows core code
to ask an auth_baton for specific kinds of credentials. The actual
implementation is hidden (i.e. looping over specific registered
providers).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Feb 27 04:07:36 2003

This is an archived mail posted to the Subversion Dev mailing list.