[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Issue 990: SWIG Python on Win32

From: Dale Hirt <dale_at_sbcltd.com>
Date: 2003-02-26 20:05:38 CET

Comments inline.

> -----Original Message-----
> From: Russell Yanofsky [mailto:rey4@columbia.edu]
> Sent: Wednesday, February 26, 2003 3:52 AM
> To: dev@subversion.tigris.org
> Subject: Re: [PATCH] Issue 990: SWIG Python on Win32
>
>
> I've attached a patch which can be applied on top of Dale's.
> It fixes a few
> issues with the python bindings and cvs2svn.py on windows which are
> described in the log message below.
>
> - Russ
>
> Log
> ============
>
> subversion/bindings/swig/INSTALL:
> * Added instructions for windows.
>
> subversion/bindings/swig/apr.i:
> * Allowed integer parameters to be passed where time_t
> is expected.

This is the problem. apr_time_t is a 64-bit integer. All sorts of nasty
things are happening here. Long is not big enough, and MSVC 6.0 doesn't
recognize long long. We need a solution that will work.

>
> subversion/bindings/swig/python/win32/libswig_svn_client.dsp
> subversion/bindings/swig/python/win32/libswig_svn_delta.dsp
> subversion/bindings/swig/python/win32/libswig_svn_fs.dsp
> subversion/bindings/swig/python/win32/libswig_svn_ra.dsp
> subversion/bindings/swig/python/win32/libswig_svn_repos.dsp
> subversion/bindings/swig/python/win32/libswig_svn_util.dsp
> subversion/bindings/swig/python/win32/libswig_svn_wc.dsp
> subversion/bindings/swig/python/win32/swig_python.dsp:
> * Changed settings on debug builds to link with LibD\apriconv.lib
> instead of LibR\apriconv.lib.

Ah, yes, that is a good change. Didn't catch that before. The dangers of
cut and paste.

>
> tools/cvs2svn/cvs2svn.py:
> * Opens RCS files in binary mode instead of text mode to prevent
> CRLF -> LF substitution on windows.
> * Leaves out buffer size argument to os.popen() to
> prevent runtime
> error on windows with python 2.2.1

Can we change this based on the os? Do we absolutely need the buffer
argument on other OS's? I'm more inclined to pass it in based on the os,
instead of just blankly omitting it.

>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 26 20:06:35 2003

This is an archived mail posted to the Subversion Dev mailing list.