[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 1019] - don't run diff on binary files

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2003-02-25 18:00:14 CET

Brandon Ehle <azverkan@yahoo.com> writes:

> >We're now using Sander's internal diff library, so the GNU 2.7/2.8
> >discussion is irrelevant. I'm changing the description of this bug to
> >the real issue. We simply need to STOP trying to run contextual diff
> >on files with obvious binary properties!
> >
> >
> The file in question was found to be a C++ text file with an
> accidental NULL character at the end (damnit Visual C). I don't know
> if that matters any or not to the solution.

In this kind of situation, the file would probably not have a
binary-property attached, and there's nothing we can really do about
that. Neither the user nor svn thinks its a binary file. But Sander
already fixed his library so that such a scenario at least won't
segfault.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Feb 25 16:01:16 2003

This is an archived mail posted to the Subversion Dev mailing list.