Re: svn commit: rev 5076 - trunk/subversion/libsvn_delta

Ben Collins-Sussman <sussman@collab.net> writes:

> Karl, what about the fact that 'make install' tries to finish by
> running 'svnversion' on the source tree? For people bootstrapping
> from a tarball, the last thing they see is a huge error from this
> command, because they don't in fact have a working copy. Then newbies
> aren't sure if 'make install' actually worked!
>
> Either 'svnversion' needs to not exit(1) on a non-wc, or 'make check'
> needs to not run svnversion if .svn isn't present. I've seen 0.18
> tarball users bitten by this already.

svnversion should not produce an error when run on a directory that is
not a working copy. There are regression tests to cover that case.
When does the error occur?

$ svn export ../svn zz
$ cd zz
$ ./autogen.sh
$ ./configure ...
$ make
$ make install
[...]
See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
----------------------------------------------------------------------
chmod 755 /usr/local/apache2/modules/mod_dav_svn.so
[activating module `dav_svn' in /usr/local/apache2/conf/httpd.conf]
subversion/svnversion/svnversion . /repos/svn/trunk > /usr/local/foo/include/subversion-1/svn-revision.txt

I don't get an error. The output of svnversion is

$ cat /usr/local/foo/include/subversion-1/svn-revision.txt
exported

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org